Details

    • Type: Bug
    • Status: Resolved (View workflow)
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 8.7.0.0
    • Component/s: None
    • Labels:
      None
    • Epic Link:
    • Sprint:
      Sprint 149, Sprint 150
    • Story Points:
      3
    • Capitalizable:
      True

      Description

      Spring managed beans currently have names that do not include the hostname. These names do not match the names that are provided by the metrics service.

      More context:

      @mario.lopez I believe that is expected, yes. Those `org.openrepose.core.services*` items at the bottom are not reported through the `MetricsService`. That is, they are managed by Spring and annotated with `@ManagedResource`. We may, however, want a story to update the `ReposeJmxNamingStrategy` used by Spring to name those MBeans.

      [10:07]
      Actually, though, it's kind of weird that those beans do no include the hostname. The `ReposeJmxNamingStrategy` bean should be adding it... or so I thought.

      [10:08]
      Ah.

      [10:08]
      > Note: This annotation is marked as inherited, allowing for generic management-aware base classes. In such a scenario, it is recommended to not specify an object name value since this would lead to naming collisions in case of multiple subclasses getting registered.

      [10:08]
      So that's not quite our situation, but I wonder if it's similar. If specifying the `objectName` is overwriting the usage of the `ReposeJmxNamingStrategy`.

      Acceptance Criteria:

      • All JMX reported metrics should include the hostname.

        Attachments

          Activity

            People

            • Assignee:
              damien.johnson Damien Johnson
              Reporter:
              damien.johnson Damien Johnson
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: