Uploaded image for project: 'Repose'
  1. REP-5737

IP User config allows empty list of groups to be configured (schema/doc/reality mismatch)

    Details

    • Type: Bug
    • Status: Resolved (View workflow)
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 8.6.3.0
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Sprint 147, Sprint 148
    • Story Points:
      2
    • Capitalizable:
      True

      Description

      The IP User filter says that it requires at least one group to be configured.

      The schema seems to confirm this intention, but in practice, this does not seem to be enforced. Andrew (Valkyrie) wanted to be able to configure no groups, and he was able to successfully do so.

      <?xml version="1.0" encoding="UTF-8"?>
      
      <ip-user xmlns="http://docs.openrepose.org/repose/ip-user/v1.0">
          <!-- Nothing is needed here -->
      </ip-user>
      

      The schema unit test for the IP User filter is not testing this, and it's not even using the new ConfigValidator to do the schema validation which it should be.

      Of note, the IP User filter docs have not been migrated yet: http://www.openrepose.org/versions/8.6.1.1/filters/ip-user.html

      Problem:
      The file path is wrong:
      https://github.com/rackerlabs/repose/blob/c277f5111d89144098891800d41402108b5bac33/repose-aggregator/components/filters/ip-user-filter/src/main/scala/org/openrepose/filters/ipuser/IpUserFilter.scala#L55

      Acceptance Criteria:

      • IP User docs are migrated to the versioned docs.
      • Unit tests for IP User schema are updated to use the new ConfigValidator.
      • The schema is tested in a functional test.
      • The release notes include a comment that anyone depending on this bug will be broken.

        Attachments

          Issue links

            Activity

              People

              • Assignee:
                wdschei Bill Scheidegger
                Reporter:
                mario.lopez Mario Lopez
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: